Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alter ups to change the name of the PIMS_ROLEs for lease/license #4545

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Add alter ups to change the name of the PIMS_ROLEs for lease/license #4545

merged 2 commits into from
Dec 24, 2024

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the bug Something isn't working label Dec 20, 2024
@devinleighsmith devinleighsmith self-assigned this Dec 20, 2024
asanchezr
asanchezr approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@asanchezr asanchezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I wonder if the same changes should be added to the BUILD folder and to the corresponding PSP_PIMS_LATEST folder as well.
Otherwise we risk loosing those changes when Doug creates a new migration

@devinleighsmith devinleighsmith merged commit 738a3c1 into bcgov:dev Dec 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanchezr asanchezr asanchezr approved these changes

Assignees

@devinleighsmith devinleighsmith

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinleighsmith @asanchezr